Add cleanup of old account events #6576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a data cleanup feature for account events: - Adds migration to perform initial cleanup of account events older than 2 years - Adds management command 'cleanup_old_account_events' for periodic cleanup - Can be scheduled via crontab to run daily The cleanup can be run manually with: python manage.py cleanup_old_account_events
akatsoulas
approved these changes
Mar 20, 2025
|
|
||
|
|
||
| def delete_old_account_events(apps, schema_editor): | ||
| AccountEvent = apps.get_model('users', 'AccountEvent') |
There was a problem hiding this comment.
In order to keep this code DRY and have a single place where we delete accounts, you can use the call_command function to call the management command that you wrote
akatsoulas
reviewed
Mar 20, 2025
| from datetime import timedelta | ||
|
|
||
|
|
||
| def delete_old_account_events(apps, schema_editor): |
There was a problem hiding this comment.
let's match the name with the one of the management command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a data cleanup feature for account events:
The cleanup can be run manually with:
python manage.py cleanup_old_account_events
This
.delete()[0]is an interesting thing I learned - delete returns a tuple.